Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add common cask issues #12616

Merged
merged 1 commit into from Dec 23, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Moved the documents from https://github.com/Homebrew/homebrew-cask/tree/HEAD/doc/reporting_bugs to common homebrew docs.

CC @Homebrew/cask

@BrewTestBot
Copy link
Member

Review period will end on 2021-12-23 at 16:23:43 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 22, 2021
### If the download works

The cask is outdated. Let’s fix it:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could/should we mention something here about using brew livecheck {{cask_name}} to check if there is a new version, followed by running brew bump-cask-pr?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all guides could use some love and updated instructions, but I'd prefer to do that in a later PR. This one is really about moving everything.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 23, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 23, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@miccal miccal merged commit e970bb1 into Homebrew:master Dec 23, 2021
@@ -113,6 +113,90 @@ xcode-select --install
brew upgrade
```

## Cask - cURL error

First, let's tackle a common problem: do you have a `.curlrc` file? Check with `ls -A ~ | grep .curlrc` (if you get a result, the file exists). Those are a frequent cause of issues of this nature. Before anything else, remove that file and try again. If it now works, do not open an issue. Incompatible `.curlrc` configurations must be fixed on your side.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even relevant anymore after HOMEBREW_CURLRC?

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
@SMillerDev SMillerDev deleted the chore/docs/common_cask_issues branch September 21, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants