Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize swift scripts in Library/Homebrew/cask/utils #12651

Merged
merged 2 commits into from Dec 31, 2021
Merged

Modernize swift scripts in Library/Homebrew/cask/utils #12651

merged 2 commits into from Dec 31, 2021

Conversation

NSAntoine
Copy link

@NSAntoine NSAntoine commented Dec 31, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The following PR modernizes the swift scripts in Library/Homebrew/cask/utils (trash.swift and quarantine.swift), by using features that are Swift-like, such as guard statements.

The functionality and usage of the 2 scripts remains the same

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @Serena-io!

@MikeMcQuaid MikeMcQuaid merged commit cf00403 into Homebrew:master Dec 31, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants