Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/pypi: ensure pipgrip is installed. #12703

Merged
merged 1 commit into from Jan 12, 2022
Merged

utils/pypi: ensure pipgrip is installed. #12703

merged 1 commit into from Jan 12, 2022

Conversation

MikeMcQuaid
Copy link
Member

Rather than failing if it isn't installed: install it if needed.

@MikeMcQuaid
utils/pypi: ensure pipgrip is installed.
a9e348c 
Rather than failing if it isn't installed: install it if needed.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 11, 2022
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 11, 2022
Merged
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Rylan12
Rylan12 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense!

@MikeMcQuaid MikeMcQuaid merged commit 1b5caa5 into Homebrew:master Jan 12, 2022
@MikeMcQuaid MikeMcQuaid deleted the ensure_pipgrip_installed branch January 12, 2022 13:27
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @BrewTestBot @carlocab @Rylan12