brew bump
: don't use Repology for versioned formulae
#12812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR proposes to avoid checking Repology for versioned formulae when
brew bump
ing them.Currently,
brew bump
's Repology output for a versioned formula shows the latest version for the corresponding non-versioned formula. This leads to incorrect PRs like Homebrew/homebrew-core#94115, Homebrew/homebrew-core#94113, Homebrew/homebrew-core#94110, etc. For example:With these changes, we have:
The message could probably improved/changed from "not found" for this particular case. I think it's fine to skip Repology altogether because:
traefik
andtraefik@1
).traefik1
) and searching through all these may be wasteful or include different packages.This would only be a problem for formulae like
openssl
where we have only versioned formulae, but there are very few of these, they're usually very popular (Python, OpenSSL, etc.) andlivecheck
is probably sufficient.