Formula: Allow cargo build when building libraries
#12819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
When building Rust packages that provide libraries but no executable binaries, `cargo install` doesn't do anything; you need to use `cargo build` and install any libraries manually. See e.g. rust-lang/cargo#8294. Unfortunately, Homebrew's Rubocop "use cargo install *std_cargo_args" rule, as currently written, blocks all invocations of `cargo build`. This commit changes that rule to exclude invocations of `cargo build` that use the `--lib` argument (`--lib` specifies to Cargo that a package's library targets should be built). This will enable library packages to be built while retaining the "use cargo install *std_cargo_args" message for the more common case when a Rust package provides executable binaries.
rolandcrosby
force-pushed
the
rubocop-cargo-lib
branch
from
d3c7729
to
d8df9c2
Compare
|
Rebased to see if that fixes the coverage check's spurious complaint about reduced coverage. |
MikeMcQuaid
added
the
critical
MikeMcQuaid
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Thanks so much for your great, first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @rolandcrosby!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?When building Rust packages that provide libraries but no executable binaries,
cargo installdoesn't do anything; you need to usecargo buildand install any libraries manually. See e.g. rust-lang/cargo#8294.Unfortunately, Homebrew's Rubocop "use
"cargo", "install", *std_cargo_args" rule, as currently written, blocks all invocations ofcargo build. This is blocking Homebrew/homebrew-core#94091 and will prevent formulas for being created for any library-only Rust packages that usecargoto build.This commit changes that rule to allow invocations of
cargo buildthat use the--libargument (--libspecifies to Cargo that a package's library targets should be built). This will enable library packages to be built, while retaining the "use"cargo", "install", *std_cargo_args" message for the more common case when a Rust package provides executable binaries.