Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/dispatch-build-bottle: Stop replacing linuxbrew-core #12895

Merged
merged 1 commit into from Feb 21, 2022
Merged

dev-cmd/dispatch-build-bottle: Stop replacing linuxbrew-core #12895

merged 1 commit into from Feb 21, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 18, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • The cores are now merged (:tada:), so the Linux core tap is homebrew-core not linuxbrew-core, everything core should have switched over, this should be safe to remove.

@issyl0
dev-cmd/dispatch-build-bottle: Stop replacing linuxbrew-core
6685f2f 
- The cores are now merged (:tada:), so the Linux core tap is
  `homebrew-core` not `linuxbrew-core`, everything core should have
  switched over, this should be safe to remove.
@BrewTestBot
Copy link
Member

Review period will end on 2022-02-21 at 16:42:14 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 18, 2022
nandahkrishna
nandahkrishna approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @issyl0!

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 18, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 21, 2022
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 88b8006 into Homebrew:master Feb 21, 2022
@issyl0 issyl0 deleted the cores-are-merged-now branch February 21, 2022 10:38
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@issyl0 @BrewTestBot @MikeMcQuaid @dawidd6 @nandahkrishna