Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: remove OnOS. #12912

Merged
merged 1 commit into from Feb 24, 2022
Merged

formula: remove OnOS. #12912

merged 1 commit into from Feb 24, 2022

Conversation

MikeMcQuaid
Copy link
Member

The comment says to do this for 3.4.0. I suspect it won't work as expected but let's give it a go and see what happens.

Do not merge until the next tag will be 3.4.0.

@BrewTestBot
Copy link
Member

Review period will end on 2022-02-23 at 09:17:34 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 22, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 22, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit a92b86d into master Feb 24, 2022
@MikeMcQuaid MikeMcQuaid deleted the formula_remove_include_on_os branch February 24, 2022 08:44
@carlocab
Copy link
Member

This broke brew bottle. I think it's from the on_macos call in def caveats.

@MikeMcQuaid
Copy link
Member Author

@carlocab Yeh, looks like it, on it.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants