Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Tips and Tricks doc, expand -s flag #12953

Merged
merged 1 commit into from Mar 4, 2022

Conversation

roryokane
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a documentation-only change, so testing and brew typecheck are definitely not necessary, and I don’t think brew style is relevant either.

Affects https://docs.brew.sh/Tips-N'-Tricks#pre-download-a-file-for-a-formula

Writing the long flag here helps the user understand what the command does. The short flag is more appropriate for interactive use of brew.

Writing the long flag here helps the user understand what the command does. The short flag is more appropriate for interactive use of `brew`.
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab merged commit 90af12f into Homebrew:master Mar 4, 2022
@roryokane roryokane deleted the expand-flag-in-tips-tricks-doc branch March 4, 2022 08:36
@MikeMcQuaid
Copy link
Member

Makes sense, thanks!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants