Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Remove an allowlist entry for blacklist usage #12954

Merged
merged 1 commit into from Mar 7, 2022
Merged

rubocop: Remove an allowlist entry for blacklist usage #12954

merged 1 commit into from Mar 7, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 4, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • The usage in the xmlsectool formula went away in Homebrew/homebrew-core@76618ad.
  • If I revert the changes in that commit and run brew style --only="Naming/InclusiveLanguage" xmlsectool, RuboCop reports an offense and suggests an alternative term.

@issyl0
rubocop: Remove an allowlist entry for blacklist usage
cec469c 
- The usage in the `xmlsectool` formula went away in
  Homebrew/homebrew-core@76618ad.
- If I revert the changes in that commit and run
  `brew style --only="Naming/InclusiveLanguage" xmlsectool`, RuboCop reports an
  offense and suggests an alternative term.
@BrewTestBot
Copy link
Member

Review period will end on 2022-03-07 at 00:30:14 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 4, 2022
@issyl0 issyl0 enabled auto-merge March 4, 2022 12:31
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 7, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@issyl0 issyl0 merged commit 8554a4e into Homebrew:master Mar 7, 2022
@issyl0 issyl0 deleted the rubocop-rm-flagged-term branch March 7, 2022 09:49
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@issyl0 @BrewTestBot @MikeMcQuaid @carlocab @Rylan12