Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "keg_relocate.rb: create generic codesign_patched_binary" #12960

Merged
merged 1 commit into from Mar 4, 2022
Merged

Revert "keg_relocate.rb: create generic codesign_patched_binary" #12960

merged 1 commit into from Mar 4, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 4, 2022

codesign_patched_binary does not live in extend/os/mac/keg_relocate so a generic method cannot be put in keg_relocate.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 4, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

My bad for merging, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 3d689eb into Homebrew:master Mar 4, 2022
@Bo98 Bo98 deleted the arm-fix branch March 4, 2022 19:26
@Bo98 Bo98 mentioned this pull request Mar 21, 2022
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid