Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Binary patching of build prefixes " #13020

Merged
merged 1 commit into from Mar 21, 2022
Merged

Revert "Binary patching of build prefixes " #13020

merged 1 commit into from Mar 21, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 21, 2022 •
edited

Reverts #12940.

Sorry for the quick revert but installing any package on arm64 is broken and requires a manual brew reinstall to fix.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 21, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 enabled auto-merge March 21, 2022 18:46
@Bo98 Bo98 merged commit 54a994a into master Mar 21, 2022
@Bo98 Bo98 deleted the revert-12940-patch_prefix2 branch March 21, 2022 18:47
@danielnachun
Copy link
Member

Shoot, I thought we had this figured out by moving it to keg instead of keg_relocate. How do we fix this properly so that we can override codesign_patched_binary while still having this generic method?

@Bo98
Copy link
Member Author

Bo98 commented Mar 21, 2022

os/mac/keg is not the same extend/os/mac/keg. Basically you'd want to move it to the latter, but I've not looked too much further than that in case there's any obstacles.

@danielnachun
Copy link
Member

Yeah I see that makes sense now. It's not clear why codesign_patched_binary is in os/mac/keg and not extend/os/mac/keg. I'll have to experiment with this for a bit.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bo98 @BrewTestBot @danielnachun