Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print set git credential cache message if a helper exists #13117

Merged
merged 1 commit into from Apr 11, 2022

Conversation

xxyzz
Copy link
Contributor

@xxyzz xxyzz commented Apr 9, 2022

when a private repository is tapped

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Return earlier if git credential helper is already used. Resolves #13097.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @xxyzz!

@MikeMcQuaid MikeMcQuaid merged commit 6a291c1 into Homebrew:master Apr 11, 2022
@xxyzz xxyzz deleted the credential branch April 11, 2022 13:39
@github-actions github-actions bot added the outdated PR was locked due to age label May 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only suggest changing taps to an ssh remote when it would be useful
2 participants