Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrange error message of 'brew edit --cask' #13120

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Apr 11, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

arrange the error message of brew edit --cask like one of brew edit --formula

  • before PR
$ brew edit --cask atomm
Usage: brew edit [options] [formula|cask ...]

Open a formula or cask in the editor set by EDITOR or HOMEBREW_EDITOR,
or open the Homebrew repository for editing if no formula is provided.

      --formula, --formulae        Treat all named arguments as formulae.
      --cask, --casks              Treat all named arguments as casks.
      --print-path                 Print the file path to be edited, without
                                   opening an editor.
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.

Error: Invalid usage: /opt/homebrew/Library/Taps/homebrew/homebrew-cask/Casks/atomm.rb doesn't exist on disk. Run brew create --set-name atomm.rb $URL to create a new formula!
  • after PR
$ brew edit --cask atomm
Usage: brew edit [options] [formula|cask ...]

--< omitted >--

Error: Invalid usage: atomm doesn't exist on disk. Run brew create --cask --set-name atomm $URL to create a new cask!

@MikeMcQuaid MikeMcQuaid merged commit 6745bb2 into Homebrew:master Apr 12, 2022
@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants