Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list: output only if installed casks are passed #13141

Merged
merged 1 commit into from Apr 13, 2022
Merged

list: output only if installed casks are passed #13141

merged 1 commit into from Apr 13, 2022

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #13139.

@BrewTestBot
Copy link
Member

Review period will end on 2022-04-14 at 14:27:28 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 13, 2022
MikeMcQuaid
MikeMcQuaid approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional style change, nice work!

Library/Homebrew/cmd/list.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 13, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 13, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 28f77c0 into Homebrew:master Apr 13, 2022
@EricFromCanada EricFromCanada deleted the list-invalid-casks branch April 13, 2022 15:33
@amadejpapez amadejpapez mentioned this pull request Apr 15, 2022
Closed
2 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'brew ls --cask --versions' behavior does not match 'brew ls'
3 participants
@EricFromCanada @BrewTestBot @MikeMcQuaid