Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/governance: import from homebrew-governance. #13167

Merged
merged 1 commit into from Apr 22, 2022

Conversation

MikeMcQuaid
Copy link
Member

Saves us having Yet Another Public Repository.

@BrewTestBot
Copy link
Member

Review period will end on 2022-04-22 at 13:02:41 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 21, 2022
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fewer public repo makes sense to me, the other repo was lightly used. But it might not to users why there’s this extra stuff? Also, do we have any other docs that reference the old repo?

@EricFromCanada
Copy link
Member

Add governance to _config.yml's exclude: list to skip the folder when building the docs site.

@MikeMcQuaid
Copy link
Member Author

Add governance to _config.yml's exclude: list to skip the folder when building the docs site.

@EricFromCanada I was actually thinking of adding these somewhere to be viewed by Jekyll, just couldn't decide where?

@EricFromCanada
Copy link
Member

If you rename the destination folder to _governance, then _config.yml can define a "governance" collection and another page can generate a dynamic list of links to each item with e.g. {% for item in site.governance %}.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 22, 2022
@BrewTestBot
Copy link
Member

Review period ended.

Saves us having Yet Another Public Repository.
@EricFromCanada
Copy link
Member

After some needless difficulty 😬 I've added an underscore to the governance folder name. I'll cook up a suggestion for how to display the collection on the site later today.

@MikeMcQuaid MikeMcQuaid merged commit c2eaeed into Homebrew:master Apr 22, 2022
@MikeMcQuaid MikeMcQuaid deleted the governance branch April 22, 2022 16:18
@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants