update/update-reset: warn when no origin remote #13187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-04-26 at 12:01:51 UTC. |
BrewTestBot
added
the
waiting for feedback
|
Thanks for the suggestions, Mike! |
MikeMcQuaid
added
the
critical
MikeMcQuaid
approved these changes
Apr 25, 2022
|
Thanks again @maxim-belkin! |
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Apr 25, 2022
|
@MikeMcQuaid, I don't think that changes introduced in this PR can cause the failure observed in "CI/test everything". I re-ran the workflow once and the error message changed. Should I rebase it or re-run the workflow again? |
|
@maxim-belkin Try to rebase and try again. If it still fails: you may have accidentally broken |
Current situation with update.sh & update-reset.sh: Upon creating a new tap and before adding remote 'origin' to it, running `brew update` produces multiple cryptic error messages. This change converts these cryptic Git messages into clear warnings about absent remote 'origin'. How to test: 1. Create a new tap using `brew tap-new` 2. Run `brew update`
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
maxim-belkin
force-pushed
the
creating-new-tap
branch
from
9699b95
to
13735bc
Compare
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Explanation of changes
Current situation with update.sh & update-reset.sh:
Upon creating a new tap and before adding remote 'origin' to it, running
brew updateproduces multiple cryptic Git error messages. This change converts these cryptic Git messages into clear warnings about absent remote 'origin'.How to test:
brew tap-newbrew updateI also noticed that variable "option" in
homebrew-update-resetwas not declared as "local", so I went ahead and fixed it.