Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superenv: prioritize dependencies' opt_lib in Linux rpath #13240

Merged
merged 1 commit into from May 5, 2022

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 4, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

From discussion in Homebrew/homebrew-core#99630 to avoid issues when trying to prioritize keg_only linkage for "drop-in" libraries (e.g. libpq, luajit-openresty, jpeg-turbo, ...)

Didn't see anyone open PR for it yet. Can discuss further if there are any odd scenarios to consider.

Will still require new bottles to update problematic RPATHs.

@BrewTestBot
Copy link
Member

Review period will end on 2022-05-05 at 06:36:46 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 4, 2022
@cho-m cho-m added the linux label May 4, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cho-m!

@carlocab carlocab enabled auto-merge May 4, 2022 08:35
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 5, 2022
@carlocab carlocab merged commit 4cc306d into Homebrew:master May 5, 2022
@cho-m cho-m deleted the linux-rpath-order branch May 18, 2022 19:11
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants