Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: update --newer-only and --quiet behavior #13397

Merged

Conversation

samford
Copy link
Member

@samford samford commented Jun 8, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It was mentioned in #13395 that skip messages are printed when livecheck's --newer-only option is used and there's currently no way to avoid this. That issue suggested an --ignore-skipped option but we agreed that it's simpler to update livecheck's behavior to omit skip messages when the --newer-only option is used. [If a user also wants to omit error messages (i.e., only printing newer formulae/casks), they can use --newer-only --quiet.]

This PR implements the aforementioned change and also brings the JSON output in line by making the --newer-only and --quiet options apply to --json runs. This gives users a bit of control over the JSON output without having to manually filter it themselves.

Resolves #13395.

@BrewTestBot
Copy link
Member

Review period will end on 2022-06-09 at 20:09:50 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 8, 2022
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jun 9, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 9, 2022
@samford samford merged commit ee0d487 into Homebrew:master Jun 9, 2022
@samford samford deleted the livecheck/omit-skipped-with-newer-only branch June 9, 2022 13:04
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew livecheck --ignore-skipped
3 participants