Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: update default match_data #13402

Merged
merged 2 commits into from Jun 10, 2022

Conversation

samford
Copy link
Member

@samford samford commented Jun 9, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

livecheck's ElectronBuilder, ExtractPlist, and Sparkle strategies did not support a regex when they were originally created but I added support for a regex when a strategy block is also provided (#12449). At the time, I forgot to add the regex value to the match_data hash, so this PR updates these strategies accordingly.

Besides that, this adds missing documentation comments (e.g., # @param regex [Regexp, nil] a regex for use in a strategy block) and makes other small comment tweaks.

@BrewTestBot
Copy link
Member

Review period will end on 2022-06-10 at 19:55:14 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 9, 2022
@samford samford changed the title livecheck: update strategy default match data livecheck: update default match_data Jun 9, 2022
@samford samford force-pushed the livecheck/update-default-match_data branch from c0d5636 to 3e00806 Compare June 9, 2022 19:56
@samford samford force-pushed the livecheck/update-default-match_data branch from 3e00806 to 1e92f08 Compare June 9, 2022 22:23
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 10, 2022
@BrewTestBot
Copy link
Member

Review period ended.

This updates these strategies to better align with the default
`match_data` value in other strategies.
@samford samford force-pushed the livecheck/update-default-match_data branch from 1e92f08 to d600b66 Compare June 10, 2022 22:25
@samford samford merged commit ad13524 into Homebrew:master Jun 10, 2022
@samford samford deleted the livecheck/update-default-match_data branch June 10, 2022 22:51
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants