Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require an argument to --bottle-tag in fetch and --cache #13485

Merged
merged 1 commit into from Jun 28, 2022

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jun 28, 2022

Fixes #13484

This PR requires that an argument is passed to --bottle-tag in brew fetch and brew --cache. Now, running these commands on their own will fail immediately:

$ brew fetch wget --bottle-tag
Error: missing argument: --bottle-tag

$ brew --cache wget --bottle-tag
Error: missing argument: --bottle-tag

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Jun 28, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@NlightNFotis
Copy link

NlightNFotis commented Jun 28, 2022

Nice, thank you for fixing this so quick!

Question - do you have any sort of tests for this? For example, regex-based tests on the output to make sure that the error message is emitted correctly and no regressions are introduced at a later point?

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 28, 2022

Question - do you have any sort of tests for this?

Yes, here

@Rylan12 Rylan12 merged commit c8d1f8a into Homebrew:master Jun 28, 2022
@Rylan12 Rylan12 deleted the bottle-tag-required branch June 28, 2022 16:06
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew fetch -bottle-tag fails with an undefined method error
4 participants