Replace sorbet-runtime-stub with sorbet-runtime

[Bo98]

Resolves #11521.

This does have more overhead than the stub but I'm not convinced it's noticeable. I've done a monkey patch disabling some more common parts of runtime checking though to be on the safer side.

If the overhead is not much, we could expxand this in the future by not doing these monkey patches and doing things such as a one-pass basic evaluation of sig blocks to allow for example abstract classes to work if we want to make use of them. We don't need to commit to full level runtime checking to do this - there's different levels on the spectrum.

Should be able to replace #13563 if the user does brew install-bundler-gems --groups= first to clear previous settings. I would still however like information to fix the install error some people have since it'll still be an issue for brew typecheck. I cannot reproduce the issue myself.

[BrewTestBot]

Review period ended.

[Bo98]

brew install-bundler-gems doesn't uninstall gems properly unless paired with updating/installing any other gem (because bundle check only fails if a declared gem is not installed - not if an installed gem is not declared), which is causing brew doctor to fail in CI. I feel like we've had that issue before.

Cop out fix is to roll it in with the next Sorbet version bump but we should probably fix it properly.

[MikeMcQuaid]

One comment about more comments but otherwise seems fine thanks 👍🏻

[MikeMcQuaid]

Cop out fix is to roll it in with the next Sorbet version bump but we should probably fix it properly.

Yeh, that'd be good.

because bundle check only fails if a declared gem is not installed - not if an installed gem is not declared

Maybe needs an explicit bundle cleanup or bundle install --cleanup (neither are correct syntax, I think) to handle these cases?

[Bo98]

Maybe needs an explicit bundle cleanup or bundle install --cleanup (neither are correct syntax, I think) to handle these cases?

bundle cleanup seems to just make #5798 resurface.

[Bo98]

Ah looks like Bundler might have finally fixed the extensions directory mess in the standalone setup.rb we have: rubygems/rubygems@a9dae93. Though that will require using a newer version of Bundler.

Not really relevant to this PR but good to know nonetheless.

Edit: ok it maybe doesn't cover the platform part yet but it's a start.

[Bo98]

Pushed a Sorbet update here since I don't really know how to handle bundle cleanup without breaking everything. This should be sufficient to pass CI.