Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require deprecate_disable module in formulary #13578

Merged
merged 1 commit into from Jul 19, 2022

Conversation

gpanders
Copy link

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This solves a recurrent issue where various brew commands (e.g. doctor, cleanup) would print the following stack trace:

Error: uninitialized constant Formulary::DeprecateDisable
Did you mean?  DeprecatedOption
/opt/homebrew/Library/Homebrew/formulary.rb:269:in `convert_to_deprecate_disable_reason_string_or_symbol'
/opt/homebrew/Library/Homebrew/formulary.rb:171:in `block in load_formula_from_api'
/opt/homebrew/Library/Homebrew/formulary.rb:139:in `initialize'
/opt/homebrew/Library/Homebrew/formulary.rb:139:in `new'
/opt/homebrew/Library/Homebrew/formulary.rb:139:in `load_formula_from_api'
/opt/homebrew/Library/Homebrew/formulary.rb:519:in `load_from_api'
/opt/homebrew/Library/Homebrew/formulary.rb:510:in `klass'
/opt/homebrew/Library/Homebrew/formulary.rb:296:in `get_formula'
/opt/homebrew/Library/Homebrew/formulary.rb:542:in `factory'
/opt/homebrew/Library/Homebrew/formulary.rb:565:in `from_rack'
/opt/homebrew/Library/Homebrew/cleanup.rb:85:in `stale_formula?'
/opt/homebrew/Library/Homebrew/cleanup.rb:58:in `stale?'
/opt/homebrew/Library/Homebrew/cleanup.rb:356:in `block in cleanup_cache'
/opt/homebrew/Library/Homebrew/cleanup.rb:339:in `each'
/opt/homebrew/Library/Homebrew/cleanup.rb:339:in `cleanup_cache'
/opt/homebrew/Library/Homebrew/cleanup.rb:222:in `clean!'
/opt/homebrew/Library/Homebrew/cmd/cleanup.rb:58:in `cleanup'
/opt/homebrew/Library/Homebrew/brew.rb:93:in `<main>'

This solves a recurrent issue where various brew commands (e.g. doctor,
cleanup) would print the following stack trace:

    Error: uninitialized constant Formulary::DeprecateDisable
    Did you mean?  DeprecatedOption
    /opt/homebrew/Library/Homebrew/formulary.rb:269:in `convert_to_deprecate_disable_reason_string_or_symbol'
    /opt/homebrew/Library/Homebrew/formulary.rb:171:in `block in load_formula_from_api'
    /opt/homebrew/Library/Homebrew/formulary.rb:139:in `initialize'
    /opt/homebrew/Library/Homebrew/formulary.rb:139:in `new'
    /opt/homebrew/Library/Homebrew/formulary.rb:139:in `load_formula_from_api'
    /opt/homebrew/Library/Homebrew/formulary.rb:519:in `load_from_api'
    /opt/homebrew/Library/Homebrew/formulary.rb:510:in `klass'
    /opt/homebrew/Library/Homebrew/formulary.rb:296:in `get_formula'
    /opt/homebrew/Library/Homebrew/formulary.rb:542:in `factory'
    /opt/homebrew/Library/Homebrew/formulary.rb:565:in `from_rack'
    /opt/homebrew/Library/Homebrew/cleanup.rb:85:in `stale_formula?'
    /opt/homebrew/Library/Homebrew/cleanup.rb:58:in `stale?'
    /opt/homebrew/Library/Homebrew/cleanup.rb:356:in `block in cleanup_cache'
    /opt/homebrew/Library/Homebrew/cleanup.rb:339:in `each'
    /opt/homebrew/Library/Homebrew/cleanup.rb:339:in `cleanup_cache'
    /opt/homebrew/Library/Homebrew/cleanup.rb:222:in `clean!'
    /opt/homebrew/Library/Homebrew/cmd/cleanup.rb:58:in `cleanup'
    /opt/homebrew/Library/Homebrew/brew.rb:93:in `<main>'
@carlocab carlocab requested a review from Bo98 July 19, 2022 15:35
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 30fda55 into Homebrew:master Jul 19, 2022
@gpanders gpanders deleted the deprecated branch July 19, 2022 15:46
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants