Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --time-cond when caching the formula api json #13584

Merged
merged 2 commits into from Jul 21, 2022

Conversation

steveh7812
Copy link

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is to fix #13583 by using --time-cond "<date>" instead of --header "If-Modified-Since: <date>" when refreshing the cached Formula API. This prevents older versions of curl (such as the Apple-supplied curl in macOS Big Sur) from writing a zero-byte .json file. My change will also skip the mtime comparison and overwrite the cache file if the cache file is empty, in order to automatically fix this issue on affected systems.

@carlocab carlocab requested a review from Rylan12 July 20, 2022 01:03
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR, @steveh7812!

@carlocab carlocab enabled auto-merge July 21, 2022 07:17
@carlocab carlocab merged commit e7fc86d into Homebrew:master Jul 21, 2022
@MikeMcQuaid
Copy link
Member

Great work @steveh7812!

@steveh7812 steveh7812 deleted the api-curl-args branch July 21, 2022 16:29
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: 767 on macOS Big Sur with HOMEBREW_INSTALL_FROM_API
4 participants