Use variations hash when installing from the API
#13605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-07-26 at 06:53:12 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
approved these changes
Jul 25, 2022
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
Formularyto include the data in the variations hash when loading a formula from the API. This means that we now load formulae with the correct dependencies, etc on all platforms, not just the one that generated the JSON output.Also, in this PR, I fixed an issue where dependencies could be duplicated. If a formula called
uses_from_macos "ruby",rubywould be listed in both theuses_from_macosanddependenciessection of the formula's JSON info (on Linux). This means that it's added as a dependency twice. Now, we all names independenciesand*_dependenciesbefore adding and, if they dep is listed underuses_from_macos, we let theuses_from_macosmethod determine whether to add it as a dep or not.