Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arch from cask stanza ordering temporarily #13679

Merged
merged 1 commit into from Aug 10, 2022

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 10, 2022

This PR temporarily removes the rule that the arch stanza must immediately follow the sha256 stanza. We haven't decided yet where the best place for this to go is, so let's not require anything specific for now to give us more flexibility. I'm working on a rubocop PR that will re-add this (among other related changes), so this is just temporary while we start to add arch stanzas and figure out the preferred styling.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Aug 10, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 enabled auto-merge August 10, 2022 19:35
@Rylan12 Rylan12 merged commit 78357d9 into Homebrew:master Aug 10, 2022
@Rylan12 Rylan12 deleted the cask-dsl-arch-ordering-fix branch August 10, 2022 20:10
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants