Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: provide formula accessor. #13705

Merged
merged 1 commit into from Aug 16, 2022
Merged

service: provide formula accessor. #13705

merged 1 commit into from Aug 16, 2022

Conversation

MikeMcQuaid
Copy link
Member

Use f because it's generally recognised as a formula and this shouldn't be widely needed/used.

Needed for Homebrew/homebrew-core#107726

@MikeMcQuaid
service: provide formula accessor.
59692b5 
Use `f` because it's generally recognised as a formula and this
shouldn't be widely needed/used.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 16, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

SMillerDev
SMillerDev approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should @formula usage be switched out too?

@MikeMcQuaid
Copy link
Member Author

Should @formula usage be switched out too?

@SMillerDev I think that's fine/more readable. Will push example to homebrew-core PR shortly.

@MikeMcQuaid MikeMcQuaid merged commit d216703 into Homebrew:master Aug 16, 2022
@MikeMcQuaid MikeMcQuaid deleted the service_formula branch August 16, 2022 08:16
@MikeMcQuaid MikeMcQuaid mentioned this pull request Aug 16, 2022
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @BrewTestBot @SMillerDev