Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not filter COLORTERM #13843

Closed
wants to merge 1 commit into from
Closed

Conversation

equal-l2
Copy link
Sponsor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

COLORTERM can be used by editors, which are called by brew edit.

`COLORTERM` can be used by editors, which are called by `brew edit`
@MikeMcQuaid
Copy link
Member

COLORTERM can be used by editors

Which editors? What does it do?

@equal-l2
Copy link
Sponsor Author

In fact, any program can make use of COLORTERM to check if the terminal supports truecolor, like using TERM to check the capability.
I used "editors" as an example because my .vimrc uses the env variable to check the truecolor support and switch features.

@MikeMcQuaid
Copy link
Member

In fact, any program can make use of COLORTERM to check if the terminal supports truecolor, like using TERM to check the capability.

Any program can use any arbitrary variable, sure.

I used "editors" as an example because my .vimrc uses the env variable to check the truecolor support and switch features.

So in this case you mean it's actually just your local configuration? If so, set HOMEBREW_COLORTERM and check that instead.

Passing on this, sorry.

@equal-l2
Copy link
Sponsor Author

COLORTERM is a common environmental variable that is automatically set by terminal emulators, and is the de-facto way for programs to check if a terminal supports truecolor support.
https://github.com/termstandard/colors#checking-for-colorterm

Though I use that just for tweaking my editor, that is more potential.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants