Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnessesary : from shellenv cmd #13867

Closed
wants to merge 1 commit into from
Closed

Conversation

Jxck
Copy link

@Jxck Jxck commented Sep 14, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@gromgit
Copy link
Member

gromgit commented Sep 15, 2022

It may not do anything useful on macOS, but it doesn't hurt, as far as I can tell.

On Linux, however, it has a very useful purpose. From the manpath(5) man page:

SEARCH PATH
[...]
If the value of $MANPATH starts with a colon, then the default search path is added at its start. If the value of $MANPATH ends with a colon, then the default search path is added at its end. If the value of $MANPATH contains a double colon (::), then the default search path is inserted in the middle of the value, between the two colons.

@Bo98
Copy link
Member

Bo98 commented Sep 15, 2022

Yes, this is intentional. We should maybe make that more obvious somehow since this has been asked before.

@Bo98 Bo98 closed this Sep 15, 2022
@MikeMcQuaid
Copy link
Member

Yes, this is intentional. We should maybe make that more obvious somehow since this has been asked before.

@Bo98 A comment in the source perhaps?

gromgit pushed a commit to gromgit/homebrew-brew that referenced this pull request Sep 15, 2022
Resolves Homebrew#13867 and (hopefully) future attempts to correct the intended functionality.
gromgit pushed a commit to gromgit/homebrew-brew that referenced this pull request Sep 15, 2022
Resolves Homebrew#13867 and (hopefully) future attempts to correct the intended functionality.
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants