Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend/ENV/std: ignore fails_with during brew test. #13913

Merged
merged 2 commits into from
Sep 22, 2022
Merged

extend/ENV/std: ignore fails_with during brew test. #13913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9bcab6
extend/ENV/std: ignore `fails_with` during `brew test`.
carlocab Sep 21, 2022
1d9ee93
Apply suggestions from code review
carlocab Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion Library/Homebrew/extend/ENV/std.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@ def setup_build_environment(formula: nil, cc: nil, build_bottle: false, bottle_a
# Os is the default Apple uses for all its stuff so let's trust them
define_cflags "-Os #{SAFE_CFLAGS_FLAGS}"

send(compiler)
begin
send(compiler)
rescue CompilerSelectionError
# We don't care if our compiler fails to build the formula during `brew test`.
raise unless testing_formula

send(DevelopmentTools.default_compiler)
end

return unless cc&.match?(GNU_GCC_REGEXP)

Expand Down