Add stable checksum to the JSON API #14030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-10-24 at 05:24:24 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
added
the
critical
MikeMcQuaid
approved these changes
Oct 21, 2022
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14029
This PR adds the stable checksum (if it exists) to the JSON API. This also updates the formula API loader to load this value if it exists. This will allow commands like
brew unpackto be run even withHOMEBREW_INSTALL_FROM_APIset. I think this can be valuable for maintainers to effectively maintain while havingHOMEBREW_INSTALL_FROM_APIset.