tests: fix under GitHub Codespaces. #14071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-11-02 at 15:43:42 UTC. |
BrewTestBot
added
the
waiting for feedback
Bo98
reviewed
Nov 1, 2022
issyl0
reviewed
Nov 1, 2022
There was a problem hiding this comment.
If I remember to export HOMEBREW_CODESPACES=1 then those unsightly /tmp errors go away and brew tests comes out mostly green.
Turns out it helps if I let the whole test suite run before commenting, eh, the initial first lot of green lulled me into a false sense of security. But the below comment is correct, it doesn't actually fix things.
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Nov 2, 2022
MikeMcQuaid
force-pushed
the
tests_codespaces
branch
from
52a01ec
to
2961132
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hacks to get
brew teststo play nice.