Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow sparkle without a macOS version #14074

Merged
merged 3 commits into from Nov 1, 2022
Merged

fix: allow sparkle without a macOS version #14074

merged 3 commits into from Nov 1, 2022

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2022-11-02 at 19:49:07 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 1, 2022
@SMillerDev SMillerDev added the critical Critical change which should be shipped as soon as possible. label Nov 1, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 1, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@SMillerDev @Bo98
Update Library/Homebrew/cask/audit.rb
f5c6667 
Co-authored-by: Bo Anderson <mail@boanderson.me>
@Bo98 Bo98 merged commit 73d535a into Homebrew:master Nov 1, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SMillerDev @BrewTestBot @Bo98