dev-cmd/bottle: add --no-all-checks #14095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Nov 4, 2022
|
Need this to unblock a few things in homebrew-core. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
brew bottle --mergein two places: test-bot (single bottle) and uploading.Currently we do
:alland identical rebottle checks in both places. This isn't correct - it should only happen on upload since test-bot does not have knowledge of what's being built on other machines.This is problematic if we want to do a rebottle but one of the bottles is the same (like in https://github.com/Homebrew/homebrew-core/actions/runs/3396065093) but others are not.
We mitigated the issue for
:allby only producing an:allbottle if there is more than one tag. This mitigation cannot be applied to the identical rebuild case since there's a desire to block identical:allrebuilds.So the idea here is to add a switch to disable these checks and pass it in test-bot.