Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit multiple uninstall stanzas in casks (short-term fix) #14398

Merged
merged 1 commit into from Jan 23, 2023

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Jan 21, 2023

Longer-term solution is described here.

Resolves #14365.

CC @MikeMcQuaid

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@alexreg alexreg changed the title Permit multiple uninstall stanzas in casks (temp) Permit multiple uninstall stanzas in casks (short-term fix) Jan 21, 2023
@MikeMcQuaid MikeMcQuaid merged commit f103b88 into Homebrew:master Jan 23, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @alexreg!

@alexreg alexreg deleted the multiple-uninstall branch January 23, 2023 14:19
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple uninstall stanzas should be allowed
2 participants