Resolve RSpec/VerifiedDoubles todos #14400
Conversation
dduugg
force-pushed
the
rspec-cop-fix
branch
2 times, most recently
from
25e0cd0
to
1262dd9
Compare
| @@ -11,6 +11,8 @@ module Dependable | |||
| # misuse in future. | |||
| RESERVED_TAGS = [:build, :optional, :recommended, :run, :test, :linked].freeze | |||
|
|
|||
| attr_reader :tags | |||
There was a problem hiding this comment.
This is a bit tangential, but moving the attr here reduces duplication, allows us to remove the matching .rbi file, and write better tests.
| @@ -3,10 +3,6 @@ | |||
|
|
|||
| describe Cask::Installer, :cask do | |||
| describe "install" do | |||
| let(:empty_depends_on_stub) { | |||
There was a problem hiding this comment.
Appears to be unused (the last reference was removed in 7d5b8a5cea122c09f297dffa6b76187c413a9565)
| clang_build_version: Version.create("600"), | ||
| ) | ||
| end | ||
| let(:versions) { class_double(DevelopmentTools, clang_build_version: Version.create("600")) } |
There was a problem hiding this comment.
I think this is the correct class_double, but it doesn't recognize llvm_build_version
| let(:hash1) { double(hash_type: "sha256", to_s: "deadbeef") } | ||
| let(:hash2) { double(hash_type: "sha256", to_s: "deadcafe") } | ||
| let(:hash1) { instance_double(Checksum, to_s: "deadbeef") } | ||
| let(:hash2) { instance_double(Checksum, to_s: "deadcafe") } |
There was a problem hiding this comment.
i think this is the correct instance_double, but it doesn't recognize hash_type
| @@ -246,11 +246,6 @@ | |||
| end | |||
|
|
|||
| describe "::create" do | |||
| it "accepts objects responding to #to_str" do | |||
There was a problem hiding this comment.
I removed this test because I think this premise is invalid. The sig for create require the input to be a String, and anything else will result in a TypeError, even if it responds to to_str:
brew/Library/Homebrew/version.rb
Line 351 in 31ed690
|
Wonderful, thanks so much for this @dduugg, this is great work! Hope to see more PRs from you here, all yours so far have been perfect and make me happy 😀 |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This PR resolves the
RSpec/VerifiedDoublesinLibrary/Homebrew/test/.rubocop_todo.ymlRelates to #14250 (apologies if this stepping on someone's toes, it's assigned but has been idle)