New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocops/lines: update hard-coded compiler check #14409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2023-01-25 at 05:29:50 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 24, 2023
1. `llvm-g{cc,++}` has been gone for a long time. We don't need to check for this anymore. 2. Also check for calling the compiler as `cc`, `c89`, `c99`, or `c++`.
carlocab
force-pushed
the
compiler-check
branch
from
January 24, 2023 06:05
5100810
to
f861ada
Compare
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jan 24, 2023
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jan 24, 2023
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jan 24, 2023
6 tasks
carlocab
force-pushed
the
compiler-check
branch
from
January 24, 2023 06:19
f861ada
to
86161e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jan 24, 2023
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jan 24, 2023
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jan 24, 2023
Needed for Homebrew/brew#14409. Closes #121389. Signed-off-by: Patrick Linnane <patrick@linnane.io> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
MikeMcQuaid
approved these changes
Jan 24, 2023
MikeMcQuaid
added
the
critical
Critical change which should be shipped as soon as possible.
label
Jan 24, 2023
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 24, 2023
Review period skipped due to |
BrewTestBot
approved these changes
Jan 24, 2023
Thanks again @carlocab! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?llvm-g{cc,++}
has been gone for a long time. We don't need to check for this anymore.cc
,c89
,c99
, orc++
.