Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/lines: update hard-coded compiler check #14409

Merged
merged 2 commits into from Jan 24, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jan 24, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  1. llvm-g{cc,++} has been gone for a long time. We don't need to check for this anymore.
  2. Also check for calling the compiler as cc, c89, c99, or c++.

@BrewTestBot
Copy link
Member

Review period will end on 2023-01-25 at 05:29:50 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 24, 2023
1. `llvm-g{cc,++}` has been gone for a long time. We don't need to check
   for this anymore.
2. Also check for calling the compiler as `cc`, `c89`, `c99`, or `c++`.
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 24, 2023
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 24, 2023
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 24, 2023
@carlocab

This comment was marked as resolved.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jan 24, 2023
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jan 24, 2023
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jan 24, 2023
Needed for Homebrew/brew#14409.

Closes #121389.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 24, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 24, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

Thanks again @carlocab!

@MikeMcQuaid MikeMcQuaid merged commit 518c961 into Homebrew:master Jan 24, 2023
@carlocab carlocab deleted the compiler-check branch January 25, 2023 01:49
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants