Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RSpec cops without violations #14417

Merged
merged 1 commit into from Jan 25, 2023

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 25, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Discovered while poking at #14408 – these cops are disabled/excluded but don't prevent any violations. (However, note the first one is under "Intentionally disabled as it doesn't fit with our code style.", but I believe this not be true, at least at this point.)

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, definitely want to enable all of these that pass!

Sometimes these things get disabled because e.g. the first implementation was buggy. Interested if you have any workflow thoughts of how to catch them to re-enable in future.

Thanks again @dduugg, wonderful work!

@MikeMcQuaid MikeMcQuaid merged commit 748c1b5 into Homebrew:master Jan 25, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants