Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor away rspec-wait #14429

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Refactor away rspec-wait #14429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion Library/Homebrew/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ gem "rspec-its", require: false
gem "rspec_junit_formatter", require: false
gem "rspec-retry", require: false
gem "rspec-sorbet", require: false
gem "rspec-wait", require: false
gem "rubocop", require: false
gem "rubocop-ast", require: false
gem "simplecov", require: false
Expand Down
3 changes: 0 additions & 3 deletions Library/Homebrew/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ GEM
rspec-sorbet (1.9.1)
sorbet-runtime
rspec-support (3.12.0)
rspec-wait (0.0.9)
rspec (>= 3, < 4)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.44.0)
Expand Down Expand Up @@ -248,7 +246,6 @@ DEPENDENCIES
rspec-its
rspec-retry
rspec-sorbet
rspec-wait
rspec_junit_formatter
rubocop
rubocop-ast
Expand Down
1 change: 0 additions & 1 deletion Library/Homebrew/test/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

require "rspec/its"
require "rspec/github"
require "rspec/wait"
require "rspec/retry"
require "rspec/sorbet"
require "rubocop/rspec/support"
Expand Down
6 changes: 2 additions & 4 deletions Library/Homebrew/test/system_command_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,8 @@
] }
}

it "returns without deadlocking" do
wait(30).for {
described_class.run(command, **options)
}.to be_a_success
it "returns without deadlocking", timeout: 30 do
expect(described_class.run(command, **options)).to be_a_success
end
end

Expand Down