apply extend/os to migrate_gcc_dependents_if_needed
#14437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Jan 26, 2023
| @@ -0,0 +1,12 @@ | |||
| # typed: false | |||
There was a problem hiding this comment.
Calling this os/mac/cmd/update-report may be better (and same for below file too)
MikeMcQuaid
reviewed
Jan 31, 2023
| @@ -9,6 +9,7 @@ | |||
| require "cli/parser" | |||
| require "settings" | |||
| require "linuxbrew-core-migration" | |||
| require "extend/os/update-report" | |||
There was a problem hiding this comment.
Suggested change
| require "extend/os/update-report" | |
| require "extend/os/cmd/update-report" |
Comment on lines
4
to
8
| if OS.mac? | ||
| require "extend/os/mac/cmd/update-report" | ||
| elsif OS.linux? | ||
| require "extend/os/linux/cmd/update-report" | ||
| end |
There was a problem hiding this comment.
Suggested change
| if OS.mac? | |
| require "extend/os/mac/cmd/update-report" | |
| elsif OS.linux? | |
| require "extend/os/linux/cmd/update-report" | |
| end | |
| if OS.linux? | |
| require "extend/os/linux/cmd/update-report" | |
| end |
| @@ -0,0 +1,12 @@ | |||
| # typed: false | |||
- repair if condition - repair require filename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?apply
extend/ostoHomebrew#migrate_gcc_dependents_if_neededbecause ofbrew/Library/Homebrew/cmd/update-report.rb
Line 296 in c477b9a