Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove String#undent 馃惖-patch #14452

Merged
merged 3 commits into from Jan 31, 2023
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 28, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If I'm understanding the use & intent correctly, undent can be replaced with the squiggly heredoc introduced in Ruby 2.3.

@apainintheneck
Copy link
Contributor

Makes sense to me. It looks like this method was added when the rubocop-cask gem got merged into the main brew repo in #5190. I assume it was originally used instead of what you changed it to because this code was probably written pre-Ruby 2.3.

@dduugg dduugg mentioned this pull request Jan 28, 2023
7 tasks
@apainintheneck apainintheneck merged commit 1e4ae4e into Homebrew:master Jan 31, 2023
@apainintheneck
Copy link
Contributor

Glad to get rid of a monkey patch. Thanks, @dduugg!

@dduugg dduugg deleted the rm-undent-mp branch January 31, 2023 06:37
@MikeMcQuaid
Copy link
Member

Thanks again @dduugg!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants