Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: add missing dev-cmd aliases #14474

Merged
merged 1 commit into from Feb 1, 2023

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Feb 1, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Closes: #14465 (I think)

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-02 at 12:52:08 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 1, 2023
@gromgit
Copy link
Member

gromgit commented Feb 1, 2023

Good catch, @dawidd6! My manual testing passes:

$ gh pr checkout 14474
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 6 (delta 4), reused 6 (delta 4), pack-reused 0
Unpacking objects: 100% (6/6), 2.10 KiB | 195.00 KiB/s, done.
From https://github.com/Homebrew/brew
 * [new ref]             refs/pull/14474/head -> fix-lc-tc-aliases
Switched to branch 'fix-lc-tc-aliases'

$ brew livecheck dash
Warning: Treating dash as a formula. For the cask, use homebrew/cask/dash
dash: 0.5.12 ==> 0.5.12

$ brew lc dash
Warning: Treating dash as a formula. For the cask, use homebrew/cask/dash
dash: 0.5.12 ==> 0.5.12

$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

$ brew livecheck dash
Warning: Treating dash as a formula. For the cask, use homebrew/cask/dash
dash: 0.5.12 ==> 0.5.12

$ brew lc dash
Warning: Treating dash as a formula.
Error: dash: Unable to get versions

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 🥇

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @dawidd6!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 1, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 1, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@dawidd6 dawidd6 merged commit 856a347 into Homebrew:master Feb 1, 2023
@dawidd6 dawidd6 deleted the fix-lc-tc-aliases branch February 1, 2023 19:26
@gromgit gromgit mentioned this pull request Feb 2, 2023
3 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew lc on some formulae or casks will throw an error
6 participants