Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license handling for API formulae #14518

Merged
merged 1 commit into from Feb 6, 2023
Merged

Fix license handling for API formulae #14518

merged 1 commit into from Feb 6, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 6, 2023

When generating the API we convert the expression to a single string but we didn't convert it back again under API installs.

This meant HOMEBREW_FORBIDDEN_LICENSES was broken in certain cases.

@Bo98 Bo98 added critical Critical change which should be shipped as soon as possible. install from api Relates to API installs labels Feb 6, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12
Copy link
Member

Rylan12 commented Feb 6, 2023

Thanks! Good catch

MikeMcQuaid
MikeMcQuaid approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 96cf41e into Homebrew:master Feb 6, 2023
@Bo98 Bo98 deleted the api-license branch February 6, 2023 14:32
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. install from api Relates to API installs outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Bo98 @BrewTestBot @Rylan12 @MikeMcQuaid @carlocab