Properly load booleans from the API #14522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 6, 2023
MikeMcQuaid
approved these changes
Feb 6, 2023
|
Thanks again @Rylan12! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14503
As pointed out by @apainintheneck, now that booleans are fixed in the JSON they're actually being converted back to strings by our parser. Lets fix this by only attempting to reverse-parse elements that are already strings and leaving everything else (i.e. booleans) as-is. This shouldn't be a problem because all of the things that get pushed through
to_h_string_gsubswill end up being a string in the JSON which means it will also go back throughfrom_h_string_gsubs