Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refix bash completions 1 #14527

Merged
merged 2 commits into from Feb 6, 2023
Merged

Refix bash completions 1 #14527

merged 2 commits into from Feb 6, 2023

Conversation

maxim-belkin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Apply changes implemented in #14467 to the right file (Library/Homebrew/completions/bash.erb) so that they persist. Changes to completions/bash/brew were generated by brew generate-man-completions

CC @MikeMcQuaid and @Rylan12

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-07 at 16:49:10 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 6, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 6, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 6, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

Thanks again @maxim-belkin, sorry for not pointing this out first time around!

@MikeMcQuaid MikeMcQuaid merged commit ebed4f5 into Homebrew:master Feb 6, 2023
@maxim-belkin
Copy link
Member Author

Thanks again @maxim-belkin, sorry for not pointing this out first time around!

No worries and thanks for merging!

Thanks for approving the changes, @nandahkrishna!

@maxim-belkin maxim-belkin deleted the refix-bash-completions-1 branch February 6, 2023 21:33
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxim-belkin @BrewTestBot @MikeMcQuaid @nandahkrishna