Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash completions: clean up basic functions #14545

Merged
merged 1 commit into from Feb 7, 2023
Merged

Bash completions: clean up basic functions #14545

merged 1 commit into from Feb 7, 2023

Conversation

maxim-belkin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • (updated) __brewcomp_words_include(): simplified
  • (removed) __brewcomp_prev(): unused.
  • __brewcomp():
    • changed list="${list}${s}${sep}" to list+="${s}${sep}" (to speed things up)
    • replaced && continue; action with || action

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-08 at 13:20:50 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 7, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @maxim-belkin!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit ea40275 into Homebrew:master Feb 7, 2023
@Nesze Nesze mentioned this pull request Feb 12, 2023
Closed
maxim-belkin added a commit to maxim-belkin/homebrew-services that referenced this pull request Feb 15, 2023
@maxim-belkin
Bash completions: add __brewcomp_prev
90cb746 
Previously, __brewcomp_prev function was provided in Homebrew/brew Bash
completion script. It was removed in Homebrew/brew#14545 because no
other function in Homebrew/brew was using it. Since Bash completions for
Homebrew/services relies on this function, we restore __brewcomp_prev
here.
@maxim-belkin maxim-belkin mentioned this pull request Feb 15, 2023
Merged
@maxim-belkin maxim-belkin deleted the bash-completions-cleanup branch February 27, 2023 17:59
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxim-belkin @BrewTestBot @MikeMcQuaid