New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add better keys and fuller values to influxDB analytics #14583
Merged
MikeMcQuaid
merged 2 commits into
Homebrew:master
from
SMillerDev:fix/analytics/improve_keys
Feb 15, 2023
Merged
fix: add better keys and fuller values to influxDB analytics #14583
MikeMcQuaid
merged 2 commits into
Homebrew:master
from
SMillerDev:fix/analytics/improve_keys
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2023-02-13 at 15:02:32 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Feb 10, 2023
MikeMcQuaid
reviewed
Feb 12, 2023
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Feb 13, 2023
Review period ended. |
BrewTestBot
approved these changes
Feb 13, 2023
SMillerDev
force-pushed
the
fix/analytics/improve_keys
branch
4 times, most recently
from
February 14, 2023 13:25
ff698a6
to
3b0d751
Compare
SMillerDev
force-pushed
the
fix/analytics/improve_keys
branch
from
February 15, 2023 13:12
3b0d751
to
50e9247
Compare
MikeMcQuaid
reviewed
Feb 15, 2023
MikeMcQuaid
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This resolves most of the issues I've talked about with @MikeMcQuaid. After this I'll drop the
install
analytics and let it populate again.