Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add better keys and fuller values to influxDB analytics #14583

Merged
merged 2 commits into from Feb 15, 2023

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This resolves most of the issues I've talked about with @MikeMcQuaid. After this I'll drop the install analytics and let it populate again.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-13 at 15:02:32 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 10, 2023
Library/Homebrew/extend/os/mac/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/mac/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/mac/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 13, 2023
@BrewTestBot
Copy link
Member

Review period ended.

@SMillerDev SMillerDev force-pushed the fix/analytics/improve_keys branch 4 times, most recently from ff698a6 to 3b0d751 Compare February 14, 2023 13:25
@SMillerDev SMillerDev marked this pull request as ready for review February 15, 2023 12:42
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit ba06013 into Homebrew:master Feb 15, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants