fix(utils/github): failure with fine-granted api tokens

[anatawa12]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Fixes #14582

With fine-granted PATs, we cannot search both PRs and issues so I fix fetch_pull_requests to search only pullrequests.

I confirmed #14582 is fixed. brew bump-formula-pr anatawa12/core/vrc-get --url https://github.com/anatawa12/vrc-get/archive/0.1.7.tar.gz --no-fork --force works well in my env.

I think it's impossible to write tests without PATs. How should I write tests?

---

brew tests failires:

Failures:

  1) pkg-config returns the correct version for libcurl
     Failure/Error: expect(pc_version("libcurl")).to eq(version)

       expected: "7.85.0"
            got: "7.84.0"

       (compared using ==)
     # ./test/os/mac/pkgconfig_spec.rb:54:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:232:in `block (3 levels) in <top (required)>'
     # ./test/spec_helper.rb:231:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

  2) pkg-config returns the correct version for sqlite3
     Failure/Error: expect(pc_version("sqlite3")).to eq(version)

       expected: "3.39.5"
            got: "3.39.4"

       (compared using ==)
     # ./test/os/mac/pkgconfig_spec.rb:116:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:232:in `block (3 levels) in <top (required)>'
     # ./test/spec_helper.rb:231:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Finished in 28.57 seconds (files took 2.11 seconds to load)
317 examples, 2 failures

Failed examples:

rspec ./test/os/mac/pkgconfig_spec.rb:48 # pkg-config returns the correct version for libcurl
rspec ./test/os/mac/pkgconfig_spec.rb:110 # pkg-config returns the correct version for sqlite3

[MikeMcQuaid]

brew tests failires:

@Bo98 thoughts on making those pkg-config tests only run on CI?

[MikeMcQuaid]

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @anatawa12!

[Bo98]

@Bo98 thoughts on making those pkg-config tests only run on CI?

The problem here is actually the lack of CI. We don't have macOS 13 CI, and won't for a few more months, so this never came up and no one else seems to have noticed.

I now know though so I'll fix it.

[MikeMcQuaid]

@Bo98 hah, gotcha, thanks ❤️. I guess could maybe be a brew doctor CI-only check or something instead?

[Bo98]

It does make sense as something that is tied to recommended Xcode version bumps (which we do have a apparently-broken??? workflow for), yes. SDK updates are the times where these versions can change.

[MikeMcQuaid]

@Bo98 yeh, feels most related to our CI machines (which we do have these tests for) rather than brew tests (where it's not obvious when it's OS-dependent)