Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duration calculation in bump-unversioned-casks. #14603

Merged
merged 1 commit into from Feb 12, 2023
Merged

Fix duration calculation in bump-unversioned-casks. #14603

merged 1 commit into from Feb 12, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 12, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-14 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2023
@apainintheneck apainintheneck added the bug Reproducible Homebrew/brew bug label Feb 12, 2023
@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 12, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@apainintheneck apainintheneck merged commit e940f77 into Homebrew:master Feb 12, 2023
@reitermarkus reitermarkus deleted the unversioned-casks branch February 13, 2023 03:17
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@apainintheneck apainintheneck apainintheneck approved these changes

Assignees
No one assigned
Labels
bug Reproducible Homebrew/brew bug critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reitermarkus @BrewTestBot @apainintheneck @Bo98