cask: replace Caskroom in API for relocated artifacts #14608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 13, 2023
MikeMcQuaid
approved these changes
Feb 13, 2023
|
Thanks @Bo98! |
Rylan12
reviewed
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #14595. It doesn't cover
android-commandlinetools, but that's the only instance I can find that would still be affected.This will fix all the other cases, like
android-platform-tools. A partial fix is worthwhile because there are some popular casks affected (android-platform-toolsaverages 500 installs a day), and is lower risk of causing any other issues (a full fix is likely something much more substantial, such as evaluating a cask source with a fake prefix).