Improve homebrew/{core,cask} autotapping. #14613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 13, 2023
MikeMcQuaid
force-pushed
the
improve_autotapping
branch
from
28e376f
to
1568474
Compare
carlocab
approved these changes
Feb 13, 2023
Library/Homebrew/brew.sh
Outdated
| @@ -805,6 +805,7 @@ then | |||
| if check-array-membership "${HOMEBREW_COMMAND}" "${NO_INSTALL_FROM_API_COMMANDS[@]}" | |||
| then | |||
| export HOMEBREW_NO_INSTALL_FROM_API=1 | |||
| export HOMEBREW_NO_INSTALL_FROM_API_SET_AUTOMATICALLY=1 | |||
There was a problem hiding this comment.
Should we set this only when HOMEBREW_NO_INSTALL_FROM_API is not already set by the user?
There was a problem hiding this comment.
@carlocab Yes, good catch.
7 tasks
carlocab
reviewed
Feb 13, 2023
|
Will the dev commands still work correctly after this without tapping the core taps automatically? Or will they break like before? |
It depends what you mean by "work correctly". If they aren't tapped and you try to |
MikeMcQuaid
force-pushed
the
improve_autotapping
branch
from
1568474
to
b549441
Compare
Don't automatically tap these when running a developer command that's not using the API. Fixes #14606
MikeMcQuaid
force-pushed
the
improve_autotapping
branch
from
b549441
to
4c8ed77
Compare
carlocab
approved these changes
Feb 14, 2023
carlocab
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't automatically tap these when running a developer command that's not using the API.
Fixes #14606